FINERACT-2476: Enable Group Savings Accounts as Guarantors with Guara…#5500
Draft
Abdelrahman-358 wants to merge 1 commit intoapache:developfrom
Draft
Conversation
Contributor
Author
|
Hi @rhopman, I opened a draft PR with the proposed fix for FINERACT-2476. Could you please confirm whether this matches the intended behavior or clarify any missing requirements? |
…ntee Percentage Requirements
Abdelrahman-358
force-pushed
the
FINERACT-2476-enable-group-savings-as-guarantors
branch
from
7d4df3d to
6612784
Compare
adamsaghy
reviewed
Feb 17, 2026
| // Example: org.apache.fineract.integrationtests.common.loans.LoanTransactionHelper.disburseLoan(java.lang.Long, | ||
| // org.apache.fineract.client.models.PostLoansLoanIdRequest) | ||
| @Deprecated(forRemoval = true) | ||
| public static Integer openGroupSavingsAccount(final RequestSpecification requestSpec, final ResponseSpecification responseSpec, |
Contributor
There was a problem hiding this comment.
Please dont introduce new functionalities which are not using the fineract-client framework!
Contributor
|
@rhopman @bharathc27 Can you please review the PR from business point of view? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.